rdblue commented on code in PR #4816:
URL: https://github.com/apache/iceberg/pull/4816#discussion_r907945509
##########
python/tests/expressions/test_expressions_base.py:
##########
@@ -175,6 +138,50 @@ def test_strs(op, string):
assert str(op) == string
[email protected](
+ "a, schema, case_sensitive, success",
+ [
+ (
+ base.In(base.UnboundReference("foo"), [literal("hello"),
literal("world")]),
+ "table_schema_simple",
+ True,
Review Comment:
It's hard to read test cases that are parameterized like this, with boolean
literals. Can you separate these into different test methods? I think that it
makes more sense to split out `success` since nearly the entire test code is
different depending on its value. And it makes sense to split out case
sensitive as well since it is easier to follow if you pass it directly to
`bind`"
```
expr.bind(schema, case_sensitive=True).term.field == ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
