wuwenchi commented on code in PR #5120: URL: https://github.com/apache/iceberg/pull/5120#discussion_r909233726
########## flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/PartitionTransformUdf.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the Licenet ideajoinet ideajoin for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.flink.sink; + +import org.apache.flink.table.annotation.DataTypeHint; +import org.apache.flink.table.annotation.InputGroup; +import org.apache.flink.table.functions.ScalarFunction; +import org.apache.iceberg.expressions.Literals; +import org.apache.iceberg.transforms.Transform; +import org.apache.iceberg.transforms.Transforms; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.TypeUtil; + +public class PartitionTransformUdf { + + public static class Truncate extends ScalarFunction { + public String eval(int num, @DataTypeHint(inputGroup = InputGroup.ANY) Object obj) { + Type type = TypeUtil.fromJavaType(obj); + Transform<Object, Object> truncate = Transforms.truncate(type, num); + Object value = truncate.apply(Literals.fromJavaType(obj).to(type).value()); + return truncate.toHumanString(value); Review Comment: For `bucket`, the original type (int) is directly returned, and the user can find the corresponding partition according to the int. But for `truncate`, if the input parameter type is binary, the original data type returned is 'ByteBuffer', and iceberg will convert it into a string after getting the buffer (https://github.com/wuwenchi/iceberg/blob/35b8558d7c0b5564fb3d47f92721534f45850cd6/api/src/main/java/org/apache/iceberg/transforms/Truncate.java#L459-L461). So, in this case, should we use string? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
