gaborkaszab commented on code in PR #5159:
URL: https://github.com/apache/iceberg/pull/5159#discussion_r909565489
##########
api/src/main/java/org/apache/iceberg/io/FileIO.java:
##########
@@ -61,6 +61,13 @@ default void deleteFile(OutputFile file) {
deleteFile(file.location());
}
+ /**
+ * Delete a folder at a given path.
+ */
+ default void deleteFolder(String path) {
+ deleteFile(path);
+ }
+
Review Comment:
Currently only empty folders could be dropped as the 'isRecursive' flag is
hardcoded to false in HadoopFileIO.
If we want to keep FileIO intact, we can then change new logic in
HiveCatalog.dropTable() to check if the FileIO is of HadoopFileIO and use its
interface to invoke dropFolder() (or could be named dropRecursive()) instead of
through FileIO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
