pvary commented on code in PR #5159:
URL: https://github.com/apache/iceberg/pull/5159#discussion_r909573453
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -171,9 +172,16 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
false /* throw NoSuchObjectException if the table doesn't exist
*/);
return null;
});
-
if (purge && lastMetadata != null) {
CatalogUtil.dropTableData(ops.io(), lastMetadata);
+
+ boolean tableOwnsLocation =
PropertyUtil.propertyAsBoolean(catalogProperties,
+ CatalogProperties.DROP_FULL_TABLE_FOLDER,
CatalogProperties.DROP_FULL_TABLE_FOLDER_DEFAULT);
+ if (tableOwnsLocation) {
+ fileIO.deleteFolder(lastMetadata.location());
Review Comment:
OTOH with the setting `DROP_FULL_TABLE_FOLDER` we really assume that only
this table puts files into these folders. If other table(s) put data to this
folder the we would not like to use this config.
That said, we still might have problems with leftover uncommitted files
which are not yet removed with `deleteOrphanFiles`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
