alexjo2144 commented on PR #5157: URL: https://github.com/apache/iceberg/pull/5157#issuecomment-1170052486
> however, making equals compare by type too looks like a good change as well. this, however, should be called out in the commit message. That's a good point, and probably the risky part of this change. Before, two `StructLikeWrapper` where both contained null `struct` fields were considered equals even if they were based off of different types. After this change, that is not true. > I should also note that I'm not sure that this is a good idea. StructLikeWrapper is not intended for comparing two arbitrary structs. Based on the class description it sounded like the whole point of the Wrapper is to be able to compare StructLikes using equals. But we don't have to do this if you'd rather leave it alone -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
