rdblue commented on PR #5157: URL: https://github.com/apache/iceberg/pull/5157#issuecomment-1171397879
> Do you mean we should do type == that.type first before invoking the equals? No, I'm saying that is the first check done in `equals` (usually) so hopefully if you're using this correctly -- that is, with the same schema for all records -- the extra check would be cheap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
