singhpk234 commented on code in PR #5156:
URL: https://github.com/apache/iceberg/pull/5156#discussion_r909940649
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java:
##########
@@ -164,6 +166,16 @@ public String extractCatalog(CaseInsensitiveStringMap
options) {
return catalogAndIdentifier(options).catalog().name();
}
+ @Override
+ public Optional<String> extractTimeTravelVersion(CaseInsensitiveStringMap
options) {
+ return Optional.ofNullable(PropertyUtil.propertyAsString(options,
"versionAsOf", null));
Review Comment:
I picked these string from the
[PR](https://github.com/apache/spark/pull/34497) that introduced time travel in
spark, but these doesn't seems to be a standard in Spark as there is no defined
constants for the same.
To not conflict with existing options that are already in iceberg such as
`as-of-timestamp` & `SNAPSHOT_ID`. Hence used the above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
