singhpk234 commented on code in PR #5156:
URL: https://github.com/apache/iceberg/pull/5156#discussion_r909944729
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java:
##########
@@ -182,6 +185,122 @@ public void testTimestampInTableName() {
assertEquals("Snapshot at timestamp " + timestamp, expected, fromDF);
}
+ @Test
+ public void testVersionAsOf() {
+ // get the snapshot ID of the last write and get the current row set as
expected
+ long snapshotId =
validationCatalog.loadTable(tableIdent).currentSnapshot().snapshotId();
+ List<Object[]> expected = sql("SELECT * FROM %s", tableName);
+
+ // create a second snapshot
+ sql("INSERT INTO %s VALUES (4, 'd', 4.0), (5, 'e', 5.0)", tableName);
+
+ // read the table at the snapshot
+ List<Object[]> actual1 = sql("SELECT * FROM %s VERSION AS OF %s",
tableName, snapshotId);
+ assertEquals("Snapshot at specific ID", expected, actual1);
+
+ // read the table at the snapshot
+ // HIVE time travel syntax
+ List<Object[]> actual2 = sql("SELECT * FROM %s FOR SYSTEM_VERSION AS OF
%s", tableName, snapshotId);
+ assertEquals("Snapshot at specific ID", expected, actual2);
+
+ // read the table using DataFrameReader option: versionAsOf
+ Dataset<Row> df = spark.read()
+ .format("iceberg")
+ .option("versionAsOf", snapshotId)
+ .load(tableName);
+ List<Object[]> fromDF = rowsToJava(df.collectAsList());
+ assertEquals("Snapshot at specific ID " + snapshotId, expected, fromDF);
+ }
+
+ @Test
+ public void testTimestampAsOf() {
+ long snapshotTs =
validationCatalog.loadTable(tableIdent).currentSnapshot().timestampMillis();
+ long timestamp = waitUntilAfter(snapshotTs + 1000);
+ waitUntilAfter(timestamp + 1000);
+ // AS OF expects the timestamp if given in long format will be of seconds
precision
+ long timestampInSeconds = TimeUnit.MILLISECONDS.toSeconds(timestamp);
+ SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
+ String formattedDate = sdf.format(new Date(timestamp));
Review Comment:
makes sense, will make the changes :) !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
