rdblue commented on code in PR #4941:
URL: https://github.com/apache/iceberg/pull/4941#discussion_r910211712
##########
core/src/main/java/org/apache/iceberg/actions/SortStrategy.java:
##########
@@ -48,7 +49,7 @@ public abstract class SortStrategy extends BinPackStrategy {
* @return this for method chaining
*/
public SortStrategy sortOrder(SortOrder order) {
- this.sortOrder = order;
Review Comment:
Can you add a check here for the unsorted order? I think that would fix the
`TestSortStrategy` test so it doesn't need to be modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
