rdblue commented on code in PR #4941:
URL: https://github.com/apache/iceberg/pull/4941#discussion_r918236433
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -1264,6 +1266,23 @@ public void testRewriteJobOrderFilesDesc() {
Assert.assertNotEquals("Number of files order should not be ascending",
actual, expected);
}
+ @Test
+ public void testPartitioningSortWithManualSortOnSameColumn() {
+ Table table = createTablePartitioned(4, 2);
+ table.refresh();
+ table.updateSpec().addField(bucket("c3", 16)).commit();
+ Assert.assertFalse(table.specs().isEmpty());
+ Assert.assertFalse(table.spec().fields().isEmpty());
Review Comment:
I don't think that these assertions are needed, since this isn't trying to
validate the behavior of `updateSpec`. This should just assume that it the
update worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
