danielcweeks commented on code in PR #5178: URL: https://github.com/apache/iceberg/pull/5178#discussion_r912267719
########## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ########## @@ -79,6 +79,7 @@ public class S3FileIO implements FileIO, SupportsBulkOperations, SupportsPrefixO private String credential = null; private SerializableSupplier<S3Client> s3; private AwsProperties awsProperties; + private Map<String, String> properties = null; Review Comment: Originally we didn't want to include all properties as part of the serialized object (this would include all catalog properties), which is why AwsProperties is a slimmed down version. Maybe we could trim this to just what the FileIO needs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
