danielcweeks commented on code in PR #5178: URL: https://github.com/apache/iceberg/pull/5178#discussion_r912281414
########## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ########## @@ -79,6 +79,7 @@ public class S3FileIO implements FileIO, SupportsBulkOperations, SupportsPrefixO private String credential = null; private SerializableSupplier<S3Client> s3; private AwsProperties awsProperties; + private Map<String, String> properties = null; Review Comment: I guess this would be necessary for any custom aws client factories as well, since they may need properties not enumerated. I guess this is probably the best we can do for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
