dungdm93 commented on code in PR #5046:
URL: https://github.com/apache/iceberg/pull/5046#discussion_r912583883
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -99,29 +102,40 @@ static class DefaultAwsClientFactory implements
AwsClientFactory {
public S3Client s3() {
return S3Client.builder()
.httpClientBuilder(configureHttpClientBuilder(httpClientType))
- .applyMutation(builder -> configureEndpoint(builder, s3Endpoint))
+ .applyMutation(builder -> configureRegion(builder, s3Endpoint))
+ .applyMutation(builder -> configureEndpoint(builder, region))
.serviceConfiguration(s3Configuration(s3PathStyleAccess,
s3UseArnRegionEnabled))
.credentialsProvider(credentialsProvider(s3AccessKeyId,
s3SecretAccessKey, s3SessionToken))
.build();
}
@Override
public GlueClient glue() {
- return
GlueClient.builder().httpClientBuilder(configureHttpClientBuilder(httpClientType)).build();
+ return GlueClient.builder()
+ .httpClientBuilder(configureHttpClientBuilder(httpClientType))
+ .applyMutation(builder -> configureEndpoint(builder, region))
Review Comment:
Yeah. It's my bad. fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
