dungdm93 commented on code in PR #5046:
URL: https://github.com/apache/iceberg/pull/5046#discussion_r912585501


##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -280,6 +280,12 @@ public class AwsProperties implements Serializable {
    */
   public static final String CLIENT_ASSUME_ROLE_REGION = 
"client.assume-role.region";
 
+  /**
+   * The value must be one of {@link software.amazon.awssdk.regions.Region}, 
such as 'us-east-1'.
+   * For more details, see 
https://docs.aws.amazon.com/general/latest/gr/rande.html
+   */
+  public static final String CLIENT_REGION = "client.region";

Review Comment:
   @rdblue , @amogh-jahagirdar I'm ok with `client`.
   But I wonder is there any cases `s3`/`glue`/`dymano` in a catalog are 
located in different region.
   So, in that case, we need different key for each service like `s3.region`, 
`glue.region` and `dymano.region`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to