nastra commented on PR #5186: URL: https://github.com/apache/iceberg/pull/5186#issuecomment-1173904112
In general the approach makes sense to me. However, when looking at the spark-runtime jar I noticed that there's a `git.properties` file with a bunch of information being added (looks like this actually comes from the `apache-arrow` lib). Here's the content of that file: ``` #Generated by Git-Commit-Id-Plugin #Sat Jan 29 05:11:45 UTC 2022 git.build.user.email= git.build.host=Mac-1643432868411.local git.dirty=true git.remote.origin.url=https\://github.com/apache/arrow git.closest.tag.name=apache-arrow-7.0.0 git.commit.id.describe-short=apache-arrow-7.0.0-0-dirty [email protected] git.commit.time=29.01.2022 @ 00\:08\:24 UTC git.commit.message.full=[Release] Update versions for 7.0.0 git.build.version=7.0.0 git.commit.message.short=[Release] Update versions for 7.0.0 git.commit.id.abbrev=e90472e git.branch=e90472e35b40f58b17d408438bb8de1641bfe6ef git.build.user.name= git.closest.tag.commit.count=0 git.commit.id.describe=apache-arrow-7.0.0-0-ge90472e-dirty git.commit.id=e90472e35b40f58b17d408438bb8de1641bfe6ef git.tags=apache-arrow-7.0.0 git.build.time=29.01.2022 @ 05\:11\:45 UTC git.commit.user.name=Krisztián Szűcs ``` I looked at https://github.com/n0mer/gradle-git-properties and was wondering whether we could actually use that plugin to generate a `git.properties` file for Iceberg. It seems the plugin lets you control which info goes into that file. Also note that we could include the Iceberg version via a `customProperty`. For completeness, here's how Arrow generates that file: https://github.com/apache/arrow/blob/master/java/pom.xml#L249-L290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
