rdblue commented on PR #5186: URL: https://github.com/apache/iceberg/pull/5186#issuecomment-1175263073
@nastra, @kbendick, the Iceberg release process builds the binaries that are pushed to maven central from the source release tarball, where there is no git directory. To use a plugin like this, we will need to make sure we have some process for generating the file and probably putting it in the source tree as part of the process, like how we [add the `version.txt` file](https://github.com/apache/iceberg/blob/master/dev/source-release.sh#L90-L91). Also, I couldn't tell from a brief look at the README, can that plugin produce a `git.properties` file that is not in the root of the Jar? We want to make sure we don't have a name conflict, so I'd prefer to have `org/apache/iceberg/git.properties` or something similar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
