Fokko commented on code in PR #5171:
URL: https://github.com/apache/iceberg/pull/5171#discussion_r914087116
##########
python/tests/conftest.py:
##########
@@ -828,9 +828,9 @@ def to_input_file(self):
def create(self, overwrite: bool = False) -> OutputStream:
output_file = open(self._path, "wb" if overwrite else "xb")
- if not isinstance(output_file, OutputStream):
- raise TypeError("Object returned from LocalOutputFile.create(...)
does not match the OutputStream protocol.")
- return output_file
+ # if not issubclass(type(output_file), OutputStream):
Review Comment:
We actually need this line for mypy to assert that it is an outputstream. I
now commented it out because it would never pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
