Fokko commented on code in PR #5171:
URL: https://github.com/apache/iceberg/pull/5171#discussion_r914087524
##########
python/tests/io/test_io_base.py:
##########
@@ -64,9 +64,9 @@ def exists(self):
def open(self) -> InputStream:
input_file = open(self.parsed_location.path, "rb")
- if not isinstance(input_file, InputStream):
- raise TypeError("Object returned from LocalInputFile.open() does
not match the OutputStream protocol.")
- return input_file
+ # if not isinstance(input_file, InputStream):
Review Comment:
We actually need this line for mypy to assert that it is an outputstream. I
now commented it out because it would never pass. By reinstating these lines,
we can remove the `type: ignore` below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
