singhpk234 commented on code in PR #5204:
URL: https://github.com/apache/iceberg/pull/5204#discussion_r914390773
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -100,7 +100,13 @@ public Filter[] pushFilters(Filter[] filters) {
List<Filter> pushed = Lists.newArrayListWithExpectedSize(filters.length);
for (Filter filter : filters) {
- Expression expr = SparkFilters.convert(filter);
+ Expression expr = null;
+ try {
+ expr = SparkFilters.convert(filter);
+ } catch (IllegalArgumentException e) {
+ // converting to Iceberg Expression failed, so this expression cannot
be pushed down
Review Comment:
[minor] should we log what were the filters that spark pushed but were
ignored ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
