huaxingao commented on PR #5204: URL: https://github.com/apache/iceberg/pull/5204#issuecomment-1178380586
BTW, I saw the CI failed (https://github.com/apache/iceberg/runs/7223837382?check_suite_focus=true) because of this test ``` org.apache.iceberg.parquet.TestBloomRowGroupFilter > testBytesEq FAILED java.lang.AssertionError: Should not read: cannot match a new generated binary at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.assertTrue(Assert.java:42) at org.junit.Assert.assertFalse(Assert.java:65) at org.apache.iceberg.parquet.TestBloomRowGroupFilter.testBytesEq(TestBloomRowGroupFilter.java:587) ``` The failure is not related to the changes in this PR. I think the failure is because bloom filter can be false positive. I will fix the bloom filter test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
