rdblue commented on code in PR #4902:
URL: https://github.com/apache/iceberg/pull/4902#discussion_r915068732
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/RewriteDataFilesProcedure.java:
##########
@@ -140,36 +141,55 @@ private RewriteDataFiles checkAndApplyOptions(InternalRow
args, RewriteDataFiles
return action.options(options);
}
- private RewriteDataFiles checkAndApplyStrategy(RewriteDataFiles action,
String strategy, SortOrder sortOrder) {
+ private RewriteDataFiles checkAndApplyStrategy(
+ RewriteDataFiles action,
+ String strategy,
+ String sortOrderString,
+ Schema schema) {
+ List<ExtendedParser.RawOrderField> zOrderFields;
+ List<ExtendedParser.RawOrderField> sortOrderFields;
+ if (sortOrderString != null) {
+ List<ExtendedParser.RawOrderField> rawOrderFields =
ExtendedParser.parseSortOrder(spark(), sortOrderString);
+ Map<Boolean, List<ExtendedParser.RawOrderField>> partitions =
rawOrderFields.stream().collect(
+ Collectors.partitioningBy(field -> field.term() instanceof
Zorder));
Review Comment:
I think this is an awkward way to split the list. A simple `for` loop would
be easier to understand and maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
