rdblue commented on code in PR #4902:
URL: https://github.com/apache/iceberg/pull/4902#discussion_r917445183
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/SparkZOrderStrategy.java:
##########
@@ -133,9 +133,23 @@ public SparkZOrderStrategy(Table table, SparkSession
spark, List<String> zOrderC
"Cannot perform ZOrdering, all columns provided were identity
partition columns and cannot be used.");
}
+ validateColumnsExistence(table, spark, zOrderColNames);
+
this.zOrderColNames = zOrderColNames;
}
+ private void validateColumnsExistence(Table table, SparkSession spark,
List<String> colNames) {
+ boolean caseSensitive =
Boolean.parseBoolean(spark.conf().get("spark.sql.caseSensitive"));
Review Comment:
After seeing what this is doing with the `caseSensitive` value, I think this
is reasonable. This is using the value to decide whether to use `findField` or
`caseInsensitiveFindField`. I don't see a good way to pass a resolver for those
cases, so this seems fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
