aokolnychyi commented on code in PR #5215:
URL: https://github.com/apache/iceberg/pull/5215#discussion_r915483283
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -267,6 +267,10 @@ private TableProperties() {
public static final String METADATA_DELETE_AFTER_COMMIT_ENABLED =
"write.metadata.delete-after-commit.enabled";
public static final boolean METADATA_DELETE_AFTER_COMMIT_ENABLED_DEFAULT =
false;
+ public static final String METRICS_MAX_INFERRED_COLUMN_DEFAULTS =
Review Comment:
The naming felt a little bit confusing to me too. After I read the
explanation, it started to make more sense. However, I am still not sure
`inferred` is the right word. Technically, we infer defaults for all columns
(after this limit it just becomes `none`). To me, this is more about limiting
the number of columns for which we persist metrics by default. Can the property
name revolve around `persist` rather than `infer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
