rdblue commented on code in PR #5215:
URL: https://github.com/apache/iceberg/pull/5215#discussion_r916029680
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -267,6 +267,10 @@ private TableProperties() {
public static final String METADATA_DELETE_AFTER_COMMIT_ENABLED =
"write.metadata.delete-after-commit.enabled";
public static final boolean METADATA_DELETE_AFTER_COMMIT_ENABLED_DEFAULT =
false;
+ public static final String METRICS_MAX_INFERRED_COLUMN_DEFAULTS =
Review Comment:
The problem with "persist" and similar is that it misses the distinction
between an explicit default (when `write.metadata.metrics.default` is set) and
an implicit default that comes from Iceberg. I think the right behavior is to
preserve what we currently do, which is to use the explicit default for all
columns. But that means that this property should obviously not apply to the
explicit default. That's why I used "inferred default".
What about changing this to include `unconfigured` or `missing`? Something
like `missing-mode-limit`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
