nastra opened a new pull request, #5221: URL: https://github.com/apache/iceberg/pull/5221
We should avoid usage of `@Test(expected = ...)` because it is not always clear from where exactly an exception is thrown. We should rather promote using `Assertions.assertThatThrownBy(...).isInstanceOf(...).hasMessage(...)` as that makes sure that we are in fact getting the right exception with the appropriate error message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
