nastra commented on code in PR #5221:
URL: https://github.com/apache/iceberg/pull/5221#discussion_r919698025
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -410,6 +410,11 @@
<property name="format" value="(void setUp\(\))|(void
setup\(\))|(void setupStatic\(\))|(void setUpStatic\(\))|(void
beforeTest\(\))|(void teardown\(\))|(void tearDown\(\))|(void
beforeStatic\(\))|(void afterStatic\(\))"/>
<property name="message" value="Test setup/teardown methods are
called before(), beforeClass(), after(), afterClass(), but not setUp, teardown,
etc."/>
</module>
+ <module name="RegexpSinglelineJava">
+ <property name="ignoreComments" value="true"/>
+ <property name="format" value="@Test\(.*expected.*\)"/>
+ <property name="message" value="Prefer using
Assertions.assertThatThrownBy(...).isInstanceOf(...) instead."/>
Review Comment:
I'm in favor of steering people towards `Assertions` usage due to greater
flexibility and more fluent assertion checks. In terms of checking the
exception message, I think this is a good practice in general, since you really
want to make sure you're getting the correct exception with the message you're
expecting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
