rdblue commented on code in PR #5235:
URL: https://github.com/apache/iceberg/pull/5235#discussion_r917446360
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -1213,6 +1213,67 @@ public void testCompleteCreateTransaction() {
Assert.assertEquals("Table location should match requested",
"file:/tmp/ns/table", table.location());
}
assertFiles(table, FILE_A);
+ assertFilesPartitionSpec(table);
+ assertPreviousMetadataFileCount(table, 0);
+ }
+
+ @Test
+ public void testCompleteCreateTransactionMultipleSchemas() {
+ C catalog = catalog();
+
+ Map<String, String> properties = ImmutableMap.of("user", "someone",
"created-at", "2022-02-25T00:38:19");
+ Transaction create = catalog.buildTable(TABLE, SCHEMA)
+ .withLocation("file:/tmp/ns/table")
+ .withPartitionSpec(SPEC)
+ .withSortOrder(WRITE_ORDER)
+ .withProperties(properties)
+ .createTransaction();
+
+ Assert.assertFalse("Table should not exist after createTransaction",
catalog.tableExists(TABLE));
+
+ create.newFastAppend().appendFile(FILE_A).commit();
+
+ UpdateSchema updateSchema = create.updateSchema().addColumn("new_col",
Types.LongType.get());
+ Schema newSchema = updateSchema.apply();
+ updateSchema.commit();
+
+ UpdatePartitionSpec updateSpec = create.updateSpec().addField("new_col");
+ PartitionSpec newSpec = updateSpec.apply();
+ updateSpec.commit();
+
+ ReplaceSortOrder replaceSortOrder =
create.replaceSortOrder().asc("new_col");
+ SortOrder newSortOrder = replaceSortOrder.apply();
+ replaceSortOrder.commit();
+
+ DataFile anotherFile = DataFiles.builder(newSpec)
+ .withPath("/path/to/data-b.parquet")
+ .withFileSizeInBytes(10)
+ .withPartitionPath("id_bucket=0/new_col=0") // easy way to set
partition data for now
+ .withRecordCount(2) // needs at least one record or else metrics will
filter it out
+ .build();
+
+ create.newFastAppend().appendFile(anotherFile).commit();
+
+ Assert.assertFalse("Table should not exist after append commit",
catalog.tableExists(TABLE));
+
+ create.commitTransaction();
+
+ Assert.assertTrue("Table should exist after append commit",
catalog.tableExists(TABLE));
+ Table table = catalog.loadTable(TABLE);
+
+ Assert.assertEquals("Table schema should match the new schema",
+ newSchema.asStruct(), table.schema().asStruct());
+ Assert.assertEquals("Table should have create partition spec",
newSpec.fields(), table.spec().fields());
+ Assert.assertEquals("Table should have create sort order",
newSortOrder.fields(), table.sortOrder().fields());
Review Comment:
Minor: I think it would make more sense to describe the new schema, spec,
and sort order as "updated" rather than "create" because these are actually
different than the created ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
