bryanck commented on code in PR #5235:
URL: https://github.com/apache/iceberg/pull/5235#discussion_r917452008
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1212,7 +1246,7 @@ public TableMetadata build() {
ImmutableList.copyOf(newSnapshotLog),
ImmutableList.copyOf(metadataHistory),
ImmutableMap.copyOf(refs),
- discardChanges ? ImmutableList.of() : ImmutableList.copyOf(changes)
+ discardChanges || base == null ? ImmutableList.of() :
ImmutableList.copyOf(changes)
Review Comment:
`TestLoadTableResponse.testHasOnlyKnownFields()` was failing, so my intent
was to make it behave like `newTableMetadata` which was setting changes to
empty, though probably my misunderstanding. I'll remove this and fix what's
going on with that test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
