szehon-ho commented on code in PR #5254:
URL: https://github.com/apache/iceberg/pull/5254#discussion_r919190974
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -114,6 +118,7 @@ public Filter[] pushFilters(Filter[] filters) {
pushed.add(filter);
} catch (ValidationException e) {
// binding to the table schema failed, so this expression cannot be
pushed down
+ LOG.warn("binding to the table schema failed, so this expression
cannot be pushed down.", e);
Review Comment:
What do you think, "Failed to bind expression to table schema, skipping push
down"?
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -105,6 +108,7 @@ public Filter[] pushFilters(Filter[] filters) {
expr = SparkFilters.convert(filter);
} catch (IllegalArgumentException e) {
// converting to Iceberg Expression failed, so this expression cannot
be pushed down
+ LOG.warn("converting to Iceberg Expression failed, so this expression
cannot be pushed down.", e);
Review Comment:
Sorry to be nitty, but capitlization does not seem right. What do think
like 'Failed to convert filter to Iceberg expression, skipping push down").
And I wonder, does it help to add the filter to the message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
