kbendick commented on code in PR #5254:
URL: https://github.com/apache/iceberg/pull/5254#discussion_r919240567
##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -105,6 +108,7 @@ public Filter[] pushFilters(Filter[] filters) {
expr = SparkFilters.convert(filter);
} catch (IllegalArgumentException e) {
// converting to Iceberg Expression failed, so this expression cannot
be pushed down
+ LOG.warn("converting to Iceberg Expression failed, so this expression
cannot be pushed down.", e);
Review Comment:
+1 to adding the filter to the message.
So here, I would think maybe LOG.warn(" 'Failed to convert filter to Iceberg
expression, skipping push down for this expression: {}", filter, e);'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
