rdblue commented on code in PR #5120:
URL: https://github.com/apache/iceberg/pull/5120#discussion_r919513942
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -624,7 +635,12 @@ public List<String> listFunctions(String dbName) throws
CatalogException {
@Override
public CatalogFunction getFunction(ObjectPath functionPath) throws
FunctionNotExistException, CatalogException {
- throw new FunctionNotExistException(getName(), functionPath);
+ CatalogFunction catalogFunction =
partitionFunctions.get(functionPath.getObjectName());
Review Comment:
I see that you've removed the `listFunctions` method, but that doesn't
actually solve the problem -- it introduces a new one. The problem is that
these functions should not be defined in every database, but that's what this
`getFunction` implementation does because it ignores
`functionPath.getDatabaseName()`.
Whatever this method does, `listFunctions` should be consistent with its
behavior. If this will load a function, then `listFunctions` should show it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
