rdblue commented on code in PR #5120:
URL: https://github.com/apache/iceberg/pull/5120#discussion_r921375735
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -624,7 +635,12 @@ public List<String> listFunctions(String dbName) throws
CatalogException {
@Override
public CatalogFunction getFunction(ObjectPath functionPath) throws
FunctionNotExistException, CatalogException {
- throw new FunctionNotExistException(getName(), functionPath);
+ CatalogFunction catalogFunction =
partitionFunctions.get(functionPath.getObjectName());
Review Comment:
You're right that these functions should be provided by the catalog and
should be automatically registered or known. That isn't the problem. The
problem is that this is effectively registering the functions in every
database. Instead, choose one database where you want the functions to live.
For stored procedures, we use `system`. I think that's a good idea here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
