rdblue commented on code in PR #5268:
URL: https://github.com/apache/iceberg/pull/5268#discussion_r922365027
##########
core/src/main/java/org/apache/iceberg/IncrementalDataTableScan.java:
##########
@@ -34,7 +35,7 @@
class IncrementalDataTableScan extends DataTableScan {
IncrementalDataTableScan(TableOperations ops, Table table, Schema schema,
TableScanContext context) {
- super(ops, table, schema, context.useSnapshotId(null));
+ super(ops, table, schema, context.useSnapshotId(null), new
LoggingScanReporter());
Review Comment:
Rather than changing so many method signatures, why not add `ScanReporter`
to the `TableScanContext`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
