rdblue commented on code in PR #5268:
URL: https://github.com/apache/iceberg/pull/5268#discussion_r922368487
##########
core/src/main/java/org/apache/iceberg/ManifestGroup.java:
##########
@@ -163,20 +171,26 @@ public CloseableIterable<FileScanTask> planFiles() {
});
DeleteFileIndex deleteFiles = deleteIndexBuilder.build();
-
boolean dropStats = ManifestReader.dropStats(dataFilter, columns);
if (!deleteFiles.isEmpty()) {
select(ManifestReader.withStatsColumns(columns));
}
Iterable<CloseableIterable<FileScanTask>> tasks = entries((manifest,
entries) -> {
+ scanMetrics.addedDataFiles().increment(manifest.addedFilesCount());
+ scanMetrics.deletedDataFiles().increment(manifest.deletedFilesCount());
Review Comment:
I think I see what you're doing with these counters now. These end up
tracking the total number of data or delete files in manifests that are
scanned, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
