rdblue commented on code in PR #5287:
URL: https://github.com/apache/iceberg/pull/5287#discussion_r922528602
##########
core/src/main/java/org/apache/iceberg/SchemaParser.java:
##########
@@ -254,8 +254,8 @@ private static Types.MapType mapFromJson(JsonNode json) {
}
public static Schema fromJson(JsonNode json) {
- Type type = typeFromJson(json);
- Preconditions.checkArgument(type.isNestedType() &&
type.asNestedType().isStructType(),
+ Type type = typeFromJson(json);
+ Preconditions.checkArgument(type != null && type.isNestedType() &&
type.asNestedType().isStructType(),
Review Comment:
Can you open a separate PR for Java fixes? This looks good to me, but we try
not to mix changes like this into other PRs to avoid commit conflicts when
cherry picking to maintain branches.
This also causes the full test suite to run for this PR, which I'm sure is
annoying!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
