rdblue commented on code in PR #5287: URL: https://github.com/apache/iceberg/pull/5287#discussion_r922532739
########## python/pyiceberg/table/base.py: ########## @@ -15,17 +15,17 @@ # specific language governing permissions and limitations # under the License. -from __future__ import annotations +from typing import Dict, Optional, Union -from abc import ABC +from pydantic import Field from pyiceberg.catalog.base import Identifier +from pyiceberg.table.metadata import TableMetadataV1, TableMetadataV2 +from pyiceberg.utils.iceberg_base_model import IcebergBaseModel -class Table(ABC): - """Placeholder for Table managed by the Catalog that points to the current Table Metadata. - - To be implemented by https://github.com/apache/iceberg/issues/3227 - """ - - identifier: str | Identifier +class Table(IcebergBaseModel): Review Comment: Does `Table` need to be serializable? I'm curious why Table extends `IcebergBaseModel`. It seems like it should be a regular class to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
