nastra opened a new pull request, #5306: URL: https://github.com/apache/iceberg/pull/5306
While working on Scan reporting (#5268) I noticed that this entire chain https://github.com/apache/iceberg/blob/eff879daa492641ac8bc829e7c4625dcdfac05fa/core/src/main/java/org/apache/iceberg/ManifestGroup.java#L218-L237 would be evaluated twice. It turns out we eventually use `CloseableIterable.concat` with those `CloseableIterables` in https://github.com/apache/iceberg/blob/eff879daa492641ac8bc829e7c4625dcdfac05fa/core/src/main/java/org/apache/iceberg/ManifestGroup.java#L198. When `CloseableIterable.concat` would check for emptyness via ``` if (!iterables.hasNext()) { return empty(); } ``` it would actually evaluate the first chain of Iterables twice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
