rdblue commented on code in PR #5306:
URL: https://github.com/apache/iceberg/pull/5306#discussion_r924741448
##########
api/src/main/java/org/apache/iceberg/io/CloseableIterable.java:
##########
@@ -148,8 +143,6 @@ public CloseableIterator<E> iterator() {
private ConcatCloseableIterator(Iterable<CloseableIterable<E>> inputs) {
this.iterables = inputs.iterator();
- this.currentIterable = iterables.next();
- this.currentIterator = currentIterable.iterator();
Review Comment:
Why was it necessary to change how these are initialized? Isn't the problem
that `iterator` is called twice on the `iterable` passed to `concat`? If that
is avoided, then I think this can stay the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
