stevenzwu commented on code in PR #4904: URL: https://github.com/apache/iceberg/pull/4904#discussion_r926205113
########## flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java: ########## @@ -31,7 +31,7 @@ import org.apache.flink.table.connector.sink.abilities.SupportsPartitioning; import org.apache.flink.types.RowKind; import org.apache.flink.util.Preconditions; -import org.apache.iceberg.flink.sink.FlinkSink; +import org.apache.iceberg.flink.sink.v2.FlinkSink; Review Comment: I would recommend let's not switch to the new impl in the first release as we are still learning the behaviors of new sink interface. it is better to provide a config for users to the new sink impl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
