stevenzwu commented on code in PR #4904:
URL: https://github.com/apache/iceberg/pull/4904#discussion_r926207024
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java:
##########
@@ -64,6 +64,10 @@
import static org.apache.iceberg.TableProperties.WRITE_DISTRIBUTION_MODE;
+/**
+ * @deprecated use {@link org.apache.iceberg.flink.sink.v2.FlinkSink}
+ **/
+@Deprecated
Review Comment:
let's not mark the current sink impl as deprecated. Once we have gain enough
confidence of the new sink impl, we can deprecate this class and switch the SQL
to the new sink impl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
