pvary commented on code in PR #5159:
URL: https://github.com/apache/iceberg/pull/5159#discussion_r928572649
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -171,9 +172,17 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
false /* throw NoSuchObjectException if the table doesn't exist
*/);
return null;
});
-
if (purge && lastMetadata != null) {
CatalogUtil.dropTableData(ops.io(), lastMetadata);
Review Comment:
If we own the full table dir - can we expect that all of the files are in
the given dir?
We might not need this `CatalogUtil.dropTableData(ops.io(), lastMetadata)`
call when `shouldDropFullTableFolder` is `true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
