pvary commented on code in PR #5159:
URL: https://github.com/apache/iceberg/pull/5159#discussion_r928576574
##########
mr/src/test/java/org/apache/iceberg/mr/hive/TestTables.java:
##########
@@ -189,16 +189,37 @@ public Table createTable(TestHiveShell shell, String
tableName, Schema schema, F
*/
public Table createTable(TestHiveShell shell, String tableName, Schema
schema, PartitionSpec spec,
FileFormat fileFormat, List<Record> records) {
+ return createTable(shell, tableName, schema, spec, fileFormat, records,
null);
+ }
+
+ /**
+ * Creates a partitioned Hive test table using Hive SQL. The table will be
in the 'default' database.
+ * The table will be populated with the provided List of {@link Record}s
using a Hive insert statement.
+ * @param shell The HiveShell used for Hive table creation
+ * @param tableName The name of the test table
+ * @param schema The schema used for the table creation
+ * @param spec The partition specification for the table
+ * @param fileFormat The file format used for writing the data
+ * @param records The records with which the table is populated
+ * @param properties Additional TblProperties to pass to the create table
statement
+ * @return The created table
+ * @throws IOException If there is an error writing data
+ */
+ public Table createTable(TestHiveShell shell, String tableName, Schema
schema, PartitionSpec spec,
Review Comment:
Could we base this change the already existing hive code?
https://github.com/apache/hive/blob/90428cc5f594bd0abb457e4e5c391007b2ad1cb8/iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestTables.java#L338-L356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
