rdblue commented on code in PR #5360:
URL: https://github.com/apache/iceberg/pull/5360#discussion_r930428620
##########
python/tests/catalog/test_catalog.py:
##########
@@ -20,43 +20,43 @@
List,
Optional,
Set,
+ Tuple,
Union,
)
import pytest
-from pyiceberg.catalog import Identifier, Properties
-from pyiceberg.catalog.base import Catalog
+from pyiceberg.catalog import Catalog
from pyiceberg.exceptions import (
AlreadyExistsError,
NamespaceNotEmptyError,
NoSuchNamespaceError,
NoSuchTableError,
)
from pyiceberg.schema import Schema
-from pyiceberg.table.base import Table
+from pyiceberg.table import Table
from pyiceberg.table.metadata import INITIAL_SPEC_ID
from pyiceberg.table.partitioning import PartitionSpec
class InMemoryCatalog(Catalog):
"""An in-memory catalog implementation for testing purposes."""
- __tables: Dict[Identifier, Table]
- __namespaces: Dict[Identifier, Properties]
+ __tables: Dict[Tuple[str, ...], Table]
Review Comment:
Maybe we should have a `typedef.py` file somewhere to handle these? I like
the definitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
