samredai commented on code in PR #5360: URL: https://github.com/apache/iceberg/pull/5360#discussion_r930463449
########## python/pyiceberg/io/__init__.py: ########## @@ -14,3 +14,187 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. +"""Base FileIO classes for implementing reading and writing table files + +The FileIO abstraction includes a subset of full filesystem implementations. Specifically, +Iceberg needs to read or write a file at a given location (as a seekable stream), as well +as check if a file exists. An implementation of the FileIO abstract base class is responsible +for returning an InputFile instance, an OutputFile instance, and deleting a file given +its location. +""" +from abc import ABC, abstractmethod +from io import SEEK_SET +from typing import Protocol, Union, runtime_checkable Review Comment: I'm not sure it's not being recognized but this was a simple `mv pyiceberg/io/base.py pyiceberg/io/__init__.py` ########## python/pyiceberg/io/__init__.py: ########## @@ -14,3 +14,187 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. +"""Base FileIO classes for implementing reading and writing table files + +The FileIO abstraction includes a subset of full filesystem implementations. Specifically, +Iceberg needs to read or write a file at a given location (as a seekable stream), as well +as check if a file exists. An implementation of the FileIO abstract base class is responsible +for returning an InputFile instance, an OutputFile instance, and deleting a file given +its location. +""" +from abc import ABC, abstractmethod +from io import SEEK_SET +from typing import Protocol, Union, runtime_checkable Review Comment: I'm not sure why it's not being recognized but this was a simple `mv pyiceberg/io/base.py pyiceberg/io/__init__.py` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
