nastra commented on code in PR #5268: URL: https://github.com/apache/iceberg/pull/5268#discussion_r930762661
########## api/src/main/java/org/apache/iceberg/metrics/ScanReport.java: ########## @@ -0,0 +1,370 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.metrics; + +import java.io.Serializable; +import java.time.Duration; +import java.util.concurrent.TimeUnit; +import org.apache.iceberg.Schema; +import org.apache.iceberg.expressions.Expression; +import org.apache.iceberg.metrics.MetricsContext.Counter; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** + * A Table Scan report that contains all relevant information from a Table Scan. + */ +public class ScanReport implements Serializable { + + private final String tableName; + private final long snapshotId; + private final Expression filter; + private final Schema projection; + private final int resultDataFiles; + private final int totalDataManifests; + private final int totalDeleteManifests; + private final int scannedDataManifests; + private final int scannedDeleteManifests; + private final int totalDataFiles; + private final int totalDeleteFiles; + private final Duration totalPlanningDuration; + private final long totalFileSizeInBytes; + private final int indexedDeleteFiles; + private final int resultDeleteFiles; + private final int skippedDataManifests; + private final int skippedDeleteManifests; + private final int skippedDataFiles; + private final int skippedDeleteFiles; + + private ScanReport( + String tableName, long snapshotId, Expression filter, Schema projection, + int resultDataFiles, int totalDataManifests, int totalDeleteManifests, int scannedDataManifests, + int scannedDeleteManifests, int totalDataFiles, int totalDeleteFiles, Duration totalPlanningDuration, + long totalFileSizeInBytes, int indexedDeleteFiles, int resultDeleteFiles, + int skippedDataManifests, int skippedDeleteManifests, + int skippedDataFiles, int skippedDeleteFiles) { + this.tableName = tableName; + this.snapshotId = snapshotId; + this.filter = filter; + this.projection = projection; + this.resultDataFiles = resultDataFiles; Review Comment: I like that idea, updated the code to reflect that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
