rdblue commented on code in PR #5268:
URL: https://github.com/apache/iceberg/pull/5268#discussion_r933629987
##########
core/src/main/java/org/apache/iceberg/DeleteFileIndex.java:
##########
@@ -502,6 +509,9 @@ DeleteFileIndex build() {
}
}
+ if (null != globalDeletes) {
+ scanMetrics.indexedDeleteFiles().increment(globalDeletes.length);
+ }
Review Comment:
I don't think this is correct. It should be the number of delete files that
were indexed for all partitions, not just the root partition. I think you
should count the entries that are processed in the first loop, or add up the
number of existing and added entries in the matching delete files as they are
read (near `readDeleteManifest`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
