ggershinsky commented on code in PR #3231:
URL: https://github.com/apache/iceberg/pull/3231#discussion_r931825742
##########
core/src/main/java/org/apache/iceberg/encryption/Ciphers.java:
##########
@@ -19,19 +19,29 @@
package org.apache.iceberg.encryption;
+import java.nio.charset.StandardCharsets;
import java.security.GeneralSecurityException;
import java.security.SecureRandom;
import javax.crypto.AEADBadTagException;
import javax.crypto.Cipher;
import javax.crypto.spec.GCMParameterSpec;
import javax.crypto.spec.SecretKeySpec;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.relocated.com.google.common.primitives.Ints;
public class Ciphers {
- private static final int NONCE_LENGTH = 12;
- private static final int GCM_TAG_LENGTH = 16;
+ public static final int NONCE_LENGTH = 12;
+ public static final int GCM_TAG_LENGTH = 16;
+ public static final String GCM_STREAM_MAGIC_STRING = "GCM1";
Review Comment:
The GCM Streams are introduced in this PR - being proposed as a part of the
Iceberg spec / standard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
