ggershinsky commented on code in PR #3231:
URL: https://github.com/apache/iceberg/pull/3231#discussion_r931833985
##########
core/src/main/java/org/apache/iceberg/encryption/Ciphers.java:
##########
@@ -53,10 +63,14 @@ public AesGcmEncryptor(byte[] keyBytes) {
this.randomGenerator = new SecureRandom();
}
- public byte[] encrypt(byte[] plainText, byte[] aad) {
+ public byte[] encrypt(byte[] plaintext, byte[] aad) {
+ return encrypt(plaintext, 0, plaintext.length, aad);
+ }
+
+ public byte[] encrypt(byte[] plaintext, int plaintextOffset, int
plaintextLength, byte[] aad) {
Review Comment:
Yep, this (and other GCM Stream fields) are not documented yet. In a way,
the GCM Streams are a simple file format, designed to add encryption and
integrity verification to existing Input/Output Streams, in a transparent (and
efficient) manner. I agree we need an explicit spec for this. Should I add a
.md file (to the `iceberg/format` folder) in this PR so we can discuss it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
