stevenzwu commented on code in PR #5050:
URL: https://github.com/apache/iceberg/pull/5050#discussion_r932831558
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/TestFlinkUpsert.java:
##########
@@ -165,6 +165,52 @@ public void testUpsertAndQuery() {
}
}
+ @Test
+ public void testUpsertOptions() {
+ String tableName = "test_upsert_options";
+ LocalDate dt20220301 = LocalDate.of(2022, 3, 1);
+ LocalDate dt20220302 = LocalDate.of(2022, 3, 2);
+
+ tableUpsertProps.remove(TableProperties.UPSERT_ENABLED);
Review Comment:
we shouldn't modify the `tableUpsertProps`, as the side effect can affect
other tests. It is better to construct a different map in this test method. I
am a little surprised and confused why the CI tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
