stevenzwu commented on code in PR #5050:
URL: https://github.com/apache/iceberg/pull/5050#discussion_r933378883
##########
docs/flink-getting-started.md:
##########
@@ -553,14 +553,18 @@ env.execute("Test Iceberg DataStream");
## Write options
-Flink write options are passed when configuring the FlinkSink, like this:
+Flink write options are passed when configuring the FlinkSink or Flink SQL
hints, like this:
```
FlinkSink.Builder builder = FlinkSink.forRow(dataStream,
SimpleDataUtil.FLINK_SCHEMA)
.table(table)
.tableLoader(tableLoader)
.set("write-format", "orc")
.set(FlinkWriteOptions.OVERWRITE_MODE, "true");
+
+INSERT INTO talbeName /*+ OPTIONS('upsert-enabled'='true')*/
+SELECT
Review Comment:
also it is probably more clear to start the SQL hints as a separate
paragraph after the Java API code snippet. e.g.
For Flink SQL, write options can be passed as hints like this
```
INSERT INTO tableName /*+ OPTIONS('upsert-enabled'='true')*/
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
